Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for pending resource deletions #5767

Closed
nelango opened this issue Apr 30, 2021 · 2 comments
Closed

Increase timeout for pending resource deletions #5767

nelango opened this issue Apr 30, 2021 · 2 comments

Comments

@nelango
Copy link

@nelango nelango commented Apr 30, 2021

Change #4531 waits for pending resource deletions before attempting to redeploy. This sometimes leads to DEPLOY_ERR_WAITING_FOR_DELETION when the wait for deletion times out. The current default timeout seems to be 2 secs. Could you please increase this default or make it configurable?

As an extension, skaffold could look into not waiting for all resources marked for deletion and only query for specific resources found in the current skaffold config to be applied.

@MarlonGamez
Copy link
Contributor

@MarlonGamez MarlonGamez commented Apr 30, 2021

This can currently be configured using flags --wait-for-deletions-max and --wait-for-deletions-delay. Would you like these to be configurable through global config or skaffold.yaml as well?

@nelango
Copy link
Author

@nelango nelango commented May 12, 2021

This can currently be configured using flags --wait-for-deletions-max and --wait-for-deletions-delay. Would you like these to be configurable through global config or skaffold.yaml as well?

That should work. Closing this and will reopen if we need these to be configurable through skaffold.yaml as well. Thanks!

@nelango nelango closed this May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants